Add .tap to .npmignore #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh jeesh. mistake on my part. thank you! |
|
patched and released as |
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 6, 2024
| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | dotenv | 16.4.5 | 16.4.7 | ## [v16.4.7](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1647-2024-12-03) ##### Changed - Ignore `.tap` folder when publishing. (oops, sorry about that everyone. - [@motdotla](https://github.com/motdotla)) [#848](motdotla/dotenv#848) ## [v16.4.6](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1646-2024-12-02) ##### Changed - Clean up stale dev dependencies [#847](motdotla/dotenv#847) - Various README updates clarifying usage and alternative solutions using [dotenvx](https://github.com/dotenvx/dotenvx)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 7, 2024
| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | dotenv | 16.4.5 | 16.4.7 | ## [v16.4.7](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1647-2024-12-03) ##### Changed - Ignore `.tap` folder when publishing. (oops, sorry about that everyone. - [@motdotla](https://github.com/motdotla)) [#848](motdotla/dotenv#848) ## [v16.4.6](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1646-2024-12-02) ##### Changed - Clean up stale dev dependencies [#847](motdotla/dotenv#847) - Various README updates clarifying usage and alternative solutions using [dotenvx](https://github.com/dotenvx/dotenvx)
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 8, 2024
| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | dotenv | 16.4.5 | 16.4.7 | ## [v16.4.7](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1647-2024-12-03) ##### Changed - Ignore `.tap` folder when publishing. (oops, sorry about that everyone. - [@motdotla](https://github.com/motdotla)) [#848](motdotla/dotenv#848) ## [v16.4.6](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1646-2024-12-02) ##### Changed - Clean up stale dev dependencies [#847](motdotla/dotenv#847) - Various README updates clarifying usage and alternative solutions using [dotenvx](https://github.com/dotenvx/dotenvx)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this morning I was checking Renovate PRs and noticed that 16.4.6 mistakenly included a bunch of extra files, as I happened to click the package diff from Renovate to skim the readme change that was called out. Needless to say, the files in
.tapfolder stood out like as sore thumb. It seems to be for test results, code coverage and debug data from the last local run and that alone causes 16.4.6 to be 456% the size of 16.4.5, jumping up from 79.1 kB to 361 kB according to NPM. I'm assuming this was caused in 949b0eb as that commit was updating thetappackage and added.tapto.gitignore.One could make the argument that it does not matter due to being a small absolute increase in size, but one could also say that with 40 million downloads weekly, the extra 24 kB in tarball size is an extra 915 GB of bandwidth per week with piles of wasted space when bundled into production copies of things. Myself? I just like clean diffs to see what changed.