Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: force-disable zerocopy for RPi OMX patch #2547

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

nmschulte
Copy link
Contributor

Resolves #2523 and likely #2542.

@ccrisan
Copy link
Collaborator

ccrisan commented Oct 24, 2020

Thanks! @jasaw do you think this should be enough for us to use the latest ffmpeg with OMX?

@ccrisan ccrisan merged commit b2182bb into motioneye-project:dev Oct 24, 2020
@JohanD78
Copy link

OMX works fine with no artifacts with the dev201025 release. Verified on both Pi3 and Pi4

@jasaw
Copy link
Collaborator

jasaw commented Oct 25, 2020

It is very interesting that we still need to patch ffmpeg to disable zerocopy because motion already disables zerocopy here: https://github.com/Motion-Project/motion/blob/0faf44fefb4126722c44020269a7593994c97102/src/ffmpeg.c#L846
Something else must be broken in ffmpeg if disabling zerocopy via av_dict_set doesn't work. :-(

@nmschulte
Copy link
Contributor Author

I'm not sure the issue is caused by this commit, but with my build, my RPi3 video seems to freeze/break. It did not do this with the same/similar configuration on 20200606 build. Rebooting seems to resolve the issue, but motion detection etc. seems to not work when it's in this frozen/broken state.

@PhinPhin
Copy link

PhinPhin commented Nov 8, 2020

with the latest build I seem to got rid of the artefacts, but I now have broken videofiles every now and then, I can download the files but neither I can play it nor can MotionEyeOS create thumbnails:

image

Very annoying, since I use motion-detection to start recording and the motion-events are kind of important. Is there another issue that would explain this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ghostimages/artefacts on recordings
5 participants