Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error on ingress or service name not specified #423

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

ashleyschuett
Copy link
Contributor

What does this PR do?

Fix template from erroring when name is omited

@ashleyschuett ashleyschuett requested a review from a team November 20, 2019 16:35
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #423 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   40.46%   40.46%           
=======================================
  Files          76       76           
  Lines        2659     2659           
=======================================
  Hits         1076     1076           
  Misses       1520     1520           
  Partials       63       63

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d75969...7829f17. Read the comment docs.

@rafaeljesus
Copy link
Contributor

rafaeljesus commented Nov 20, 2019

:shipit:

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr

@ashleyschuett ashleyschuett merged commit 680e0cb into master Nov 20, 2019
@rafaeljesus rafaeljesus deleted the patch/fix-templates branch November 20, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants