fix: make 'pull' nonblocking (supporting more than 100 new issues)

moul · Jul 22, 2019 · 76904b7 · 76904b7
1 parent 0b1e427
commit 76904b7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/pkg/issues/github.go b/pkg/issues/github.go
@@ -26,7 +26,7 @@ func githubPull(target Target, wg *sync.WaitGroup, token string, db *gorm.DB, ou
 	if err := db.Where("repository_id = ?", target.ProjectURL()).Order("updated_at desc").First(&lastEntry).Error; err == nil {
 		callOpts.Since = lastEntry.UpdatedAt
 	} else {
-		zap.L().Warn("failed to get last entry", zap.Error(err))
+		zap.L().Warn("failed to get last entry", zap.String("repo", target.ProjectURL()), zap.Error(err))
 	}
 
 	for {

diff --git a/pkg/issues/issue.go b/pkg/issues/issue.go
@@ -48,8 +48,12 @@ func PullAndCompute(githubToken, gitlabToken string, db *gorm.DB, t Targets) err
 			panic("should not happen")
 		}
 	}
-	wg.Wait()
-	close(out)
+
+	go func() {
+		wg.Wait()
+		close(out)
+	}()
+
 	for issues := range out {
 		allIssues = append(allIssues, issues...)
 	}