Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor depviz #147

Merged
merged 16 commits into from
Dec 27, 2018
Merged

refactor: refactor depviz #147

merged 16 commits into from
Dec 27, 2018

Conversation

ahamidullah
Copy link
Contributor

@ahamidullah ahamidullah commented Dec 3, 2018

Major change is separation of package main into pkg/issues and pkg/airtabledb.
Also some general code cleanup, commenting, etc.

┆Issue is synchronized with this Trello card

@guardrails
Copy link

guardrails bot commented Dec 3, 2018

⚠️ We detected security issues in this pull request:

Insecure Use of Dangerous Function (1)

More info on how to fix Insecure Use of Dangerous Function in Go.

@moul
Copy link
Owner

moul commented Dec 7, 2018

As depviz is a monobinary, I prefer to keep the main at the root of the directory

./cmd/... is suggested for "ecosystem repositories" that contains multiple mains and that are primarily used as golang libraries

Depviz is an application first that is more often downloaded as is than used as packages

@moul
Copy link
Owner

moul commented Dec 7, 2018

the package airtableDB should be named airtabledb to avoid case sensitive issues with package managers etc

@ahamidullah ahamidullah changed the title refactor: split package main refactor: refactor depviz Dec 13, 2018
Copy link
Owner

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moul moul merged commit 88a632c into moul:master Dec 27, 2018
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants