-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dbt utility for modularity #1095
Open
austinweisgrau
wants to merge
3
commits into
move-coop:main
Choose a base branch
from
austinweisgrau:dbt_bq
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5faf4b2
to
c066e86
Compare
72dbeef
to
24565bd
Compare
636e109
to
d35ae67
Compare
d35ae67
to
099113a
Compare
I do not feel qualified to approve, but having the |
099113a
to
56d83d6
Compare
3c9cfc9
to
f96ba4b
Compare
f96ba4b
to
a942360
Compare
The build step is failing due to an unrelated dependency conflict, I think it's only triggering on this PR and not others because this one updates the docs folder |
12833fe
to
c7b7ff9
Compare
c7b7ff9
to
0876c5d
Compare
0876c5d
to
2bec4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes uncouple the code for the dbt utility that runs a dbt command from the code that logs dbt commands. This allows for modular use of different loggers and a very flexible ability to customize logging. This addresses the main concerns from the original PR (#841).
Breaking changes
This PR does cause breaking changes with the previous implementation of the dbt utility, but those changes are well worth it for a much cleaner and clearer interface.
Using the new implementation looks like:
The prior implementation was potentially only compatible with Redshift, depending on how the user's dbt
profiles.yaml
was set up. The new implementation allows the dbt process to inherit the shell environment from the python parent process, and is therefore compatible with running dbt on any database, and the user can configure credential passing using environment variables (recommended) or any other method.Improved documentation
There is now much more thorough documentation throughout the 4 modules containing the dbt utility code.
TO DO: