Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update old reference to Parsons API key type #1103

Merged

Conversation

SorenSpicknall
Copy link
Collaborator

Resolves #1084 by updating the language previously used to refer to the now-nonexistent "Parsons" API key type provisioned by NGPVAN, pointing users to request a custom integration instead.

Copy link

@rdhyee rdhyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read #1084 and the text of the revision and as a project newbie, the change sounds good to me. I'm going to be bold and hit "Approve" but I'd want someone like @shaunagm to say yes or no.

Copy link
Collaborator

@shaunagm shaunagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tempted to add a 😞 emoji here lol but approved

@shaunagm shaunagm merged commit c7ac48e into move-coop:main Jul 26, 2024
18 checks passed
@shaunagm
Copy link
Collaborator

And thanks for the initial review @rdhyee!

@SorenSpicknall SorenSpicknall deleted the soren-van_api_key_docs_update branch August 1, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NGPVAN authentication docs need to be updated
3 participants