-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch boost::shared_ptr to std::shared_ptr. #57
Conversation
This arose out of moveit/moveit#215 (comment) and following. The only question I have about this is whether this breaks |
Note that CI seems to be failing because moveit is also getting build, but still using Regarding |
+1 switching everything to C++11 at once makes sense to me. @de-vri-es is right the Travis build is fine for geometric_shapes, though @de-vri-es did you run the geometric_shapes tests manually to ensure those are ok? If built with moveit/moveit#215 will everything pass? |
@davetcoleman Locally I can build For moveit/moveit#215 some more changes are needed to moveit. I got it building locally, but since it depends on this PR it makes sense to decide on this one before updating the other (merge can be done at the same time). |
ok, +1 to this request as is |
Looks like we all agree on this PR, but it should not be merged until @de-vri-es has moveit/moveit#215 ready to merge with it |
moveit/moveit#215 is updated for this PR (but there might be more to do there, see comments there). |
Thanks @de-vri-es ! |
This PR swaps out
boost::shared_ptr
forstd::shared_ptr
and one occasion ofboost::scoped_ptr
withstd::unique_ptr
(the latter one was internal, not part of the API).geometric_shapes
was already usingstd::shared_ptr
for octrees for compatibility with fcl 0.5, with this PR everything will be the sameshared_ptr
type.The C++11 check is also added to
bodies.h
header, since it also requires C++11 with this PR.