Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI job for building docker images for tutorial on main #2449

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented Oct 13, 2023

Description

Here is the docker job we talked about yesterday. This should build a docker image on the main branch in CI for rolling, humble, and iron and push to the github container registry on pushes to main. The docker tag will be ghcr.io/ros-planning/moveit2:main-tutorial-${ROS_DISTRO}. I made it a separate workflow from the docker one because I want this to also run in PRs as a CI job and separate from the normal CI one because I only want it to run on pushes to the main branch.

@tylerjw tylerjw requested a review from MarqRazz October 13, 2023 14:02
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1e4721a) 50.47% compared to head (d0b9d02) 50.38%.

❗ Current head d0b9d02 differs from pull request most recent head ce5ec4e. Consider uploading reports for the commit ce5ec4e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2449      +/-   ##
==========================================
- Coverage   50.47%   50.38%   -0.08%     
==========================================
  Files         385      385              
  Lines       31829    31829              
==========================================
- Hits        16062    16034      -28     
- Misses      15767    15795      +28     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tylerjw tylerjw force-pushed the tutorial-main-docker branch 3 times, most recently from cb02f45 to d0b9d02 Compare October 13, 2023 14:33
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
Copy link
Contributor

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I locally built this image on my machine and it works! Thanks @tylerjw!

@tylerjw tylerjw merged commit 6108bff into moveit:main Oct 13, 2023
17 of 18 checks passed
m-elwin pushed a commit to m-elwin/moveit2 that referenced this pull request Dec 4, 2023
Signed-off-by: Tyler Weaver <maybe@tylerjw.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants