Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/ports moveit 3522 #3070

Merged
merged 19 commits into from
Nov 8, 2024
Merged

Enhancement/ports moveit 3522 #3070

merged 19 commits into from
Nov 8, 2024

Conversation

rr-tom-noble
Copy link
Contributor

@rr-tom-noble rr-tom-noble commented Nov 8, 2024 •
edited
Loading

Description

Ports moveit/moveit#3522 to moveit2. Should fix #2857

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference (fixes bug)
  • Document API changes relevant to the user in the MIGRATION.md notes (fixes bug)
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI (No GUI changes)
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mergify Mergify
Copy link

mergify bot commented Nov 8, 2024

This pull request is in conflict. Could you fix it @rr-tom-noble?

@rr-tom-noble
Copy link
Contributor Author

@sjahr I believe the remaining failures are unrelated to this PR (gz_ros2_control install, robotiq_driver compile error, failing panda kdl test).

Additionally, it'd be great if this could be marked for backporting to humble. I'll be able to test that #2857 is fixed.

sjahr
sjahr approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just FYI: The failing test cases are expected to fail (unfortunately) so don't mind them in future PRs.

@sjahr sjahr added backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron labels Nov 8, 2024
@sjahr sjahr added this pull request to the merge queue Nov 8, 2024
Merged via the queue into moveit:main with commit 4c28a74 Nov 8, 2024
11 of 13 checks passed
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
@rr-tom-noble @mergify
Enhancement/ports moveit 3522 (#3070)
b2e773d 
* Makes PTP changes

* Makes LIN changes

* Makes CIRC changes

* Makes CIRC changes

* Makes CIRC changes

* Makes CIRC changes

* Makes LIN changes

* Makes LIN changes

* Fixes formatting

* Replace ROS_WARN with RCLCPP_WARN

* Fixes formatting

* Fixes RCLCPP_WARN calls

* Fixes compiler errors

* Fixes if statement

* Fixes formatting

* Fixes msg type

(cherry picked from commit 4c28a74)
@mergify mergify bot mentioned this pull request Nov 8, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
@rr-tom-noble @mergify
Enhancement/ports moveit 3522 (#3070)
7d15fd1 
* Makes PTP changes

* Makes LIN changes

* Makes CIRC changes

* Makes CIRC changes

* Makes CIRC changes

* Makes CIRC changes

* Makes LIN changes

* Makes LIN changes

* Fixes formatting

* Replace ROS_WARN with RCLCPP_WARN

* Fixes formatting

* Fixes RCLCPP_WARN calls

* Fixes compiler errors

* Fixes if statement

* Fixes formatting

* Fixes msg type

(cherry picked from commit 4c28a74)

# Conflicts:
#	moveit_planners/pilz_industrial_motion_planner/src/trajectory_generator_circ.cpp
#	moveit_planners/pilz_industrial_motion_planner/src/trajectory_generator_lin.cpp
@mergify mergify bot mentioned this pull request Nov 8, 2024
Closed
6 tasks
@TSNoble TSNoble mentioned this pull request Nov 9, 2024
Merged
@rr-tom-noble rr-tom-noble mentioned this pull request Nov 12, 2024
Closed
sea-bass pushed a commit that referenced this pull request Nov 13, 2024
@mergify
Enhancement/ports moveit 3522 (backport #3070) (#3074)
7132ddd
@rr-tom-noble rr-tom-noble deleted the enhancement/ports-moveit-3522 branch November 24, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjahr sjahr sjahr approved these changes

Assignees
No one assigned
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PILZ Industrial motion planner is ignoring the goal frame_id passed
2 participants
@rr-tom-noble @sjahr