Fix: Resolve race condition in MoveGroupSequenceAction #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `ReentrantCallbackGroup` with `MutuallyExclusiveCallbackGroup` in `MoveGroupSequenceAction::initialize` to prevent race conditions during stress testing. This change ensures sequential execution of callbacks, avoiding issues caused by concurrent execution. Reference: moveit#3117
sea-bass
approved these changes
Nov 22, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3125 +/- ##
==========================================
- Coverage 50.74% 45.44% -5.30%
==========================================
Files 392 482 +90
Lines 32553 40431 +7878
==========================================
+ Hits 16517 18370 +1853
- Misses 16036 22061 +6025 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
sea-bass
added
the
backport-humble
|
I don't know what started causing these |
stephanie-eng
approved these changes
Nov 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
(cherry picked from commit 6d94dfb) # Conflicts: # moveit_planners/pilz_industrial_motion_planner/src/move_group_sequence_action.cpp
6 tasks
|
Humble backport is in #3127, and CI seems to be passing there. |
sea-bass
pushed a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced
ReentrantCallbackGroupwithMutuallyExclusiveCallbackGroupinMoveGroupSequenceAction::initializeto prevent race conditions during stress testing.This change ensures sequential execution of callbacks, avoiding issues caused by concurrent execution.
Reference: #3117
Checklist