Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEMP: Remove ros-*-geometric-shapes to force using source package #3137

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Nov 28, 2024

Description

Testing the effects of moveit/geometric_shapes#253 in CI.

Turns out that until a release of geometric_shapes is cut, we can temporarily uninstall the binaries in CI.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@rhaschke
Copy link
Contributor

Note that moveit/geometric_shapes#253 only takes effect after a new release or if the binary package (and its headers in /opt/ros//include/geometric_shapes/) are removed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.00%. Comparing base (94a68c8) to head (b9f0ed8).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3137      +/-   ##
==========================================
- Coverage   46.01%   46.00%   -0.00%     
==========================================
  Files         483      483              
  Lines       40632    40632              
==========================================
- Hits        18691    18687       -4     
- Misses      21941    21945       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass
Copy link
Contributor Author

sea-bass commented Nov 28, 2024

Note that moveit/geometric_shapes#253 only takes effect after a new release or if the binary package (and its headers in /opt/ros//include/geometric_shapes/) are removed.

I see. So should we pin to the "hack" commit for now, and cut a release of geometric_shapes for the next sync?

I'm doubtful of the effectiveness of a temporary apt remove in CI since apt may choose to remove other packages.

@rhaschke
Copy link
Contributor

We just need to remove the installed binary package.

@sea-bass
Copy link
Contributor Author

Seems that alone didn't quite work, unless there's some caching that is persisting

@sea-bass
Copy link
Contributor Author

Nah, it just does not have binary installs to remove, it seems

  Reading state information... Done
  E: Unable to locate package ros-.*-geometric-shapes
  E: Couldn't find any package by glob 'ros-.*-geometric-shapes'

https://github.com/moveit/moveit2/actions/runs/12072620084/job/33666989895?pr=3137#step:11:261

@rhaschke
Copy link
Contributor

For some reason, the glob didn't work. Using the exact name should work now.

@rhaschke
Copy link
Contributor

And of course we need -y to avoid apt waiting for user input...

@rhaschke
Copy link
Contributor

This works. Reverting change to moveit2.repos...

@rhaschke rhaschke marked this pull request as ready for review November 28, 2024 20:23
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged. After releasing and syncing geometric_shapes, the commit should be reverted.

@rhaschke rhaschke changed the title Test fixes to geometric_shapes in CI TEMP: Remove ros-*-geometric-shapes to force using source package Nov 28, 2024
@sea-bass
Copy link
Contributor Author

For some reason, the glob didn't work. Using the exact name should work now.

I think apt might use * instead of .* for its glob, but anyways I like specifying it with the ROS distro environment variable better.

@rhaschke
Copy link
Contributor

I think apt might use * instead of .* for its glob

No, surprisingly all glob/regex variants didn't work.

@sea-bass sea-bass merged commit 1404825 into main Nov 29, 2024
13 checks passed
@sea-bass sea-bass deleted the sea-bass-patch-1 branch November 29, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants