Robot state port #80
Merged
Robot state port #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: vmayoral <v.mayoralv@gmail.com> Co-authored-by: anasarrak <anasarrak@gmail.com>
Co-authored-by: vmayoral <v.mayoralv@gmail.com> Co-authored-by: anasarrak <anasarrak@gmail.com>
Co-authored-by: anasarrak <anasarrak@gmail.com>
Co-Authored-By: Dave Coleman <dave@picknik.ai>
Co-Authored-By: Dave Coleman <dave@picknik.ai>
|
@davetcoleman fixed CMakelists.txt issues |
| #include <chrono> | ||
| #include <gtest/gtest.h> |
There was a problem hiding this comment.
How are the changes in this file related to the port?
There was a problem hiding this comment.
it's not part of the port (code-wise) but I had to modify the CMakelists.txt with ament_add_gtest. So I used this opportunity to also fix the tests.
Co-Authored-By: Henning Kayser <henningkayser@picknik.ai>
mlautman
approved these changes
May 21, 2019
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@henningkayser I have applied all the changes that you requested in a this new PR. Please close this one #59