Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change max distance in Connect stages in MTC tutorial #904

Closed
wants to merge 2 commits into from

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented May 3, 2024

Description

I was just trying to get MoveIt 2 tutorials working on Ubuntu 24.04 / Rolling and came back to this long-overdue fix.

This PR implements the suggestion from @rhaschke in moveit/moveit_task_constructor#540 (comment), which indeed fixes things on my end as well.

@sea-bass sea-bass requested review from rhaschke and sjahr May 3, 2024 20:24
@sea-bass sea-bass self-assigned this May 3, 2024
@rhaschke
Copy link
Contributor

rhaschke commented May 4, 2024

I think, it would be more useful to change the default setting in the Connect stage as I did in moveit/moveit_task_constructor#542. Unfortunately, nobody approved this PR yet.
By the way, I noticed, that Humble doesn't need this relaxation of the threshold. Hence, there was some change in the main branch of MoveIt2, which causes this issue. The best solution would be to revert this change in MoveIt2!
Closing here.

@rhaschke rhaschke closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants