Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial Docker image names and documentation #989

Merged
merged 2 commits into from
Nov 17, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Nov 17, 2024

Description

This PR updates the Docker images used in the tutorials to the new moveit Docker Hub organization.

It also updates docs associated with this change, plus how to build documentation locally with virtual environments (needed for Ubuntu 24.04, introduced in #916)

I also tested all the combinations for Humble, Jazzy, and Rolling, and the demo.launch.py actually work in all 3 cases! Magical.

Closes #918
Closes #936

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

Copy link
Contributor

@stephanie-eng stephanie-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏
Minor consistency nitpick but thank you for fixing the tutorials.

I'm not able to test this out right now, but looks generally good to me.

@sea-bass sea-bass merged commit ff8b169 into main Nov 17, 2024
9 checks passed
@sea-bass sea-bass deleted the fix-docker-images branch November 17, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants