Skip to content
This repository has been archived by the owner on Nov 13, 2017. It is now read-only.

Switch to std::shared_ptr for FCL and octomap types. #726

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Switch to std::shared_ptr for FCL and octomap types. #726

merged 1 commit into from
Jul 27, 2016

Conversation

de-vri-es
Copy link
Contributor

More boost::shared_ptr to std::shared_ptr conversions for FCL 0.5.

Needs moveit/geometric_shapes#47 and moveit/moveit_core#316

See also moveit/moveit_core#315

@davetcoleman
Copy link
Member

This worked for me - now I'm getting an error in moveit_fake_controller_manager ;-)

@de-vri-es
Copy link
Contributor Author

Interesting, that passed for me without problems iirc. I'm currently looking at the unit tests, because those don't compile even in moveit_core now. Will have a close look at moveit_fake_controller_manager after those.

@de-vri-es
Copy link
Contributor Author

@davetcoleman: I found the issue with moveit_fake_controller_manager. C++11 is not enabled there. I didn't notice it myself because I use gcc 6 which defaults to C++14.

Could you (or someone else) make a kinetic-devel branch for moveit_plugins?

@davetcoleman
Copy link
Member

I didn't notice it myself because I use gcc 6 which defaults to C++14

Have you ever used Docker? I'm going to setup one for all these PRs so we can verify in a clean environment that they work

Could you (or someone else) make a kinetic-devel branch for moveit_plugins?

Done

@de-vri-es
Copy link
Contributor Author

Have you ever used Docker? I'm going to setup one for all these PRs so we can verify in a clean environment that they work

Yes. we're using docker for a CI server at the office to also test on Ubuntu. I don't have it set-up at home though. I should do that at some point :)

Done

Awesome, thanks.

@davetcoleman davetcoleman mentioned this pull request Jul 26, 2016
9 tasks
@davetcoleman
Copy link
Member

The set of C++11 changes required for FCL 0.5 discussed here are now passing in Kinetic in this test environment. Note that the kinetic branch will continue not to work without installing from source the latest Octomap and FCL, but these will soon be released. Merging all related PRs.

@davetcoleman davetcoleman merged commit 7099c3a into moveit:kinetic-devel Jul 27, 2016
otamachan pushed a commit to otamachan/moveit_ros that referenced this pull request Oct 22, 2017
Switch to std::shared_ptr for FCL and octomap types.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants