Run goalcallback asynchronously #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ros2 #496 +/- ##
==========================================
- Coverage 42.82% 42.41% -0.40%
==========================================
Files 82 83 +1
Lines 7967 8043 +76
==========================================
Hits 3411 3411
- Misses 4556 4632 +76 ☔ View full report in Codecov by Sentry. |
sea-bass
reviewed
Oct 23, 2023
sea-bass
approved these changes
Oct 24, 2023
|
A little hard to read, but it's right on the edge of "these lambdas should call a member function" and "it's short enough to all be inline". I'm OK with this. |
sjahr
commented
Oct 26, 2023
MarqRazz
approved these changes
Oct 26, 2023
rhaschke
pushed a commit
to ubi-agni/moveit_task_constructor
that referenced
this pull request
Mar 9, 2024
- Rename goalCallback() -> execCallback() - Run execCallback asynchronously and use future to know status of execution
rhaschke
pushed a commit
to ubi-agni/moveit_task_constructor
that referenced
this pull request
Mar 10, 2024
* Run goalCallback in a seperate asynchronously * Clang-tidy fixes * Replace std::bind with lambdas * Add comment * Format --------- Co-authored-by: JafarAbdi <cafer.abdi@gmail.com>
rhaschke
added a commit
to ubi-agni/moveit_task_constructor
that referenced
this pull request
Mar 10, 2024
- Rename goalCallback() -> execCallback() - Revert transition to lambdas, which made the code less readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally address this comment in #461.
Disclaimer: I am not the original author of these changes.
This changes the behavior of the execute_task_solution_capability to not accept new execution requests if another request is currently processed. I assume the reason for this is to avoid interruptions because of incorrect execution commands. It is still possible to abort the execution with the CancelCallback.