Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made call to compute_cartesian_path more pythonic; added links to mov… #96

Closed

Conversation

jwhendy
Copy link
Contributor

@jwhendy jwhendy commented Aug 4, 2017

…eit_commander API

I tweaked the tutorial intro, as MoveGroupCommander is used just a much as RobotCommander, so it seemed fair to highlight both, and I added a link to the API a well, which I found really helpful when getting my hands dirty (just nice to see all the calls one has available).

While I'm new, from what I've seen in python blogs various talks on python, using named arguments seemed more elegant/pythonic than un-named arguments with comments after them, especially since the variables were named perfectly already.

0.0) # jump_threshold
waypoints=waypoints,
eef_step=0.01,
jump_threshold=0.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love this!

@davetcoleman
Copy link
Member

i just retriggered the build

@davetcoleman
Copy link
Member

You have a slight syntax error:

Warning, treated as error:
/home/travis/build/ros-planning/moveit_tutorials/doc/ros_visualization/visualization_tutorial.rst:100: WARNING: Bullet list ends without a blank line; unexpected unindent.

@jwhendy
Copy link
Contributor Author

jwhendy commented Aug 24, 2017

I think I've figured this all out...

So! If you take #109, I think this will then pass as well.

@v4hn v4hn closed this in #109 Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants