-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update industrial_ci_action.yml #122
Conversation
revomed old ros2 galactic. add ros2 iron
fix node16 deprecation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ros2 #122 +/- ##
==========================================
+ Coverage 67.09% 68.92% +1.83%
==========================================
Files 3 4 +1
Lines 641 698 +57
Branches 0 87 +87
==========================================
+ Hits 430 481 +51
- Misses 211 213 +2
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a few minor changes required.
@@ -50,7 +50,7 @@ jobs: | |||
with: | |||
name: test-results | |||
path: ${{ env.BASEDIR }}/target_ws/**/test_results/**/*.xml | |||
- uses: codecov/codecov-action@v3 | |||
- uses: codecov/codecov-action@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codecov-action@v4 is broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to fixed now.
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
revomed old ros2 galactic.
add ros2 iron
removed node16 deprecation