Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update industrial_ci_action.yml #122

Merged
merged 4 commits into from
May 15, 2024
Merged

Update industrial_ci_action.yml #122

merged 4 commits into from
May 15, 2024

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented May 15, 2024

revomed old ros2 galactic.
add ros2 iron
removed node16 deprecation

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.92%. Comparing base (ad17b8d) to head (a39af1d).
Report is 1 commits behind head on ros2.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             ros2     #122      +/-   ##
==========================================
+ Coverage   67.09%   68.92%   +1.83%     
==========================================
  Files           3        4       +1     
  Lines         641      698      +57     
  Branches        0       87      +87     
==========================================
+ Hits          430      481      +51     
- Misses        211      213       +2     
- Partials        0        4       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a few minor changes required.

@@ -50,7 +50,7 @@ jobs:
with:
name: test-results
path: ${{ env.BASEDIR }}/target_ws/**/test_results/**/*.xml
- uses: codecov/codecov-action@v3
- uses: codecov/codecov-action@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov-action@v4 is broken

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to fixed now.

.github/workflows/industrial_ci_action.yml Outdated Show resolved Hide resolved
Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com>
@rhaschke rhaschke merged commit cc304b1 into moveit:ros2 May 15, 2024
8 checks passed
@mosfet80 mosfet80 deleted the patch-1 branch May 15, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants