Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jazzy to CI #128

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Add Jazzy to CI #128

merged 2 commits into from
Oct 2, 2024

Conversation

sea-bass
Copy link

@sea-bass sea-bass commented Oct 2, 2024

Split off this change from #127 as ended up being unrelated, but still nice to have.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment.

@@ -16,16 +16,18 @@ jobs:
matrix:
env:
- {
ROS_DISTRO: iron, ROS_REPO: main, CCOV_UPLOAD: true,
ROS_DISTRO: jazzy, ROS_REPO: main, CCOV_UPLOAD: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make sense to have this special ccov-build running on rolling?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fine to me, will change.

@sea-bass sea-bass merged commit 4710753 into ros2 Oct 2, 2024
2 checks passed
@sea-bass sea-bass deleted the add-jazzy-ci branch October 2, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants