Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git Hygiene #52

Merged
merged 4 commits into from
May 14, 2024
Merged

Git Hygiene #52

merged 4 commits into from
May 14, 2024

Conversation

l-monninger
Copy link
Collaborator

Summary

  • Status: draft
  • RFCs: $\emptyset$
  • Categories: misc

Proposes CODEOWNERS and PR.md for git hygiene.

Core Software Components

N/A

Ancillary Software Components

N/A

Testing

N/A

Outstanding Issues

  1. Any other templates we want to include? Issue template?

0xmovses
0xmovses reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@0xmovses 0xmovses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed, just two thoughts.

PR.md Outdated Show resolved Hide resolved
PR.md Show resolved Hide resolved
@l-monninger
Copy link
Collaborator Author

Updated. See if that's more to your liking.

0xmovses
0xmovses approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@0xmovses 0xmovses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l-monninger
Copy link
Collaborator Author

I think you mean RD.

@l-monninger
Copy link
Collaborator Author

@mzabaluev @musitdev @andyjsbell Going to merge to get a template in since we have a lot of activity at the moment.

@l-monninger l-monninger merged commit 4c7bd16 into main May 14, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmovses 0xmovses 0xmovses approved these changes

@mzabaluev mzabaluev Awaiting requested review from mzabaluev mzabaluev is a code owner

@andyjsbell andyjsbell Awaiting requested review from andyjsbell

@musitdev musitdev Awaiting requested review from musitdev musitdev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-monninger @0xmovses