Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update model.py to support callbacks for named_components #2

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

moversekostas
Copy link
Contributor

or add support for any torch module in the hierarchy or
add support specifically for named_components

Copy link
Contributor

@tzole1155 tzole1155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is better to follow a different logic and search for Callbacks within the different modules of the model (e.g. components. monads, objectives, monitors. etc.).

So if we want to search for Callbacks within the components:

for module in model.named_components.values():
  if isinstance(module, Callback):
     self.data.append(module)

@moversekostas
Copy link
Contributor Author

self.data.extend((c for c in model.children() if isinstance(c, Callback))) is redundant and do not perform any valid operation. thus should be removed

@tzole1155 tzole1155 merged commit b56dfa3 into main Nov 19, 2024
4 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants