Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log out request ID when the plugin is enabled #236

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

lucianjon
Copy link
Contributor

Without this we can't actually correlate back to a bramble request

@lucianjon lucianjon requested a review from a team as a code owner December 3, 2023 21:52
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (07dc77d) 72.36% compared to head (c3708dc) 72.33%.

Files Patch % Lines
plugins/request_id.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   72.36%   72.33%   -0.03%     
==========================================
  Files          27       27              
  Lines        2790     2791       +1     
==========================================
  Hits         2019     2019              
- Misses        630      631       +1     
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucianjon lucianjon merged commit a7ea311 into main Dec 3, 2023
4 checks passed
@lucianjon lucianjon deleted the log-request-id branch December 3, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants