feat: OpenTelemetry tracing and metrics #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 72.34% 69.51% -2.84%
==========================================
Files 27 28 +1
Lines 3920 4212 +292
==========================================
+ Hits 2836 2928 +92
- Misses 934 1132 +198
- Partials 150 152 +2 ☔ View full report in Codecov by Sentry. |
pkqk
reviewed
Jan 15, 2024
pkqk
reviewed
Jan 16, 2024
asger-noer
force-pushed
the
opentelemetry
branch
from
dabfbbf to
4f72c83
Compare
pkqk
reviewed
Jan 18, 2024
asger-noer
force-pushed
the
opentelemetry
branch
2 times, most recently
from
e36c1a8 to
7ec99fe
Compare
This PR adds build-in support for OpenTelemetry. All GraphQL queries to the federated services served from bramble are instrumented, this includes service schema updates, service list updates, as well as federated queries from users. The telemetry is exported using the gRPC exporter.
asger-noer
force-pushed
the
opentelemetry
branch
from
7ec99fe to
2fecc7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telemetry
This PR adds build-in support for OpenTelemetry. All GraphQL queries to the federated services served from bramble are instrumented, this includes service schema updates, service list updates, as well as federated queries from users. The telemetry is exported using the gRPC exporter.
Configuration
Since telemetry is build into bramble the configuration also lives in the bramble root
config.json.enabledwill enable telemetry.urlare the url for the collector other system capable of receiving OTLP metrics and spans.insecureallows skipping the TLS check when communicating with the collector.service_nameallows for the span service name to be set. Useful in multi-deployment settings.GraphQLClientchangesThe GraphQL client has been changed so it now returns the raw timeout error if such error is received. This allows for easier error type checking the processing the error.
Testing
Modified the
TestQueryExecutionServiceTimeoutto check on the type instead of an error string. This required some modifications to the run function, that now take a function that will test the response, moving the actual testing back into the overall test function itself. Nice.