Update protocol for backend #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
L-jasmine
commented
Feb 27, 2024
L-jasmine
commented
- I replaced std::sync::mpsc with crossbeam, as I believe it offers better performance.
- I added some new commands: Chat, and LoadModel.
- I moved the Sender for sending responses to the Command, which may make it clearer which command the response is coming from.
|
This PR is only for reference purposes for PR1, and there is no need to merge it. |
Gotcha! I'm currently looking at the comments and thinking in your suggestion number #3, which is an interesting one for sure. Will follow up in the original PR whenever makes sense, otherwise I will be commenting here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.