Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CTMS/Acoustic integration to not require a static set of newsletters #256

Closed
data-sync-user opened this issue Sep 8, 2021 · 1 comment
Closed

Update CTMS/Acoustic integration to not require a static set of newsletters #256

data-sync-user opened this issue Sep 8, 2021 · 1 comment
Assignees
@leplatrem

Comments

@data-sync-user
Copy link

data-sync-user commented Sep 8, 2021 •
edited
Loading

As a MoCo or MoFo marketing professional, I want to be able to self-service my need to create new newsletters, so that I can be responsive to changing business needs without needing support from IT or other engineering resources.

This means being able to set up a new newsletter by making configuration changes to Basket and Acoustic, and without any corresponding code change in CTMS being necessary.

Acceptance criteria: the static list of newsletters in our CTMS/Acoustic integration code has been replaced by a mechanism that acquires the newsletters slugs from Basket dynamically.

┆Issue is synchronized with this Jira Story
@leplatrem leplatrem self-assigned this Nov 11, 2022
leplatrem added a commit to leplatrem/ctms-api that referenced this issue Nov 15, 2022
@leplatrem
Read Acoustic Newsletters mapping from database (ref mozilla-it#256)
10173a5
leplatrem added a commit to leplatrem/ctms-api that referenced this issue Nov 15, 2022
@leplatrem
Read Acoustic Newsletters mapping from database (ref mozilla-it#256)
0de3d5f
@leplatrem leplatrem mentioned this issue Nov 15, 2022
Merged
leplatrem added a commit that referenced this issue Nov 15, 2022
@leplatrem
Ref #256: Store list of Acoustic fields in the database (#448)
1f53cac 
* Store list of Acoustic fields in the database

* Add command to add/remove Acoustic fields

* Run Alembic migrations in tests setup

* Adjust tests now that test DB has real data

* Rebase migration revisions

* Address @grahamalama and @bsieber-mozilla feedback

* Use pylint: disable-next
leplatrem added a commit to leplatrem/ctms-api that referenced this issue Nov 15, 2022
@leplatrem
Read Acoustic Newsletters mapping from database (ref mozilla-it#256)
7463ef9
leplatrem added a commit that referenced this issue Nov 17, 2022
@leplatrem
Ref #256: Move newsletters mapping to database (#456)
055c3de 
* Read Acoustic Newsletters mapping from database (ref #256)

* Mention command in docs

* Use official return codes

* Use os.EX_DATAERR instead of os.EX_NOTFOUND (available in Unix only)

* Address code review comments

* Address changes on the acoustic_fields command too

* Adjust usage info in commands
@leplatrem
Copy link
Contributor

This was done, but never closed (see #448 and #456)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leplatrem leplatrem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leplatrem @data-sync-user