Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests to remove count-based query assertions #457

Closed
bsieber-mozilla opened this issue Nov 15, 2022 · 0 comments · Fixed by #459 or #520
Closed

Refactor tests to remove count-based query assertions #457

bsieber-mozilla opened this issue Nov 15, 2022 · 0 comments · Fixed by #459 or #520
Assignees
@leplatrem

Comments

@bsieber-mozilla
Copy link
Contributor 

    I added an operation that introduces a new SQL statement. Therefore I incremented the value and modified the code comment.

We could invest some time in the unit tests, but I personally would prefer if we wouldn't block this PR for that

Originally posted by @leplatrem in #448 (comment)
@leplatrem leplatrem self-assigned this Nov 15, 2022
@leplatrem leplatrem changed the title Refactor tests to remote count-based query assertions Refactor tests to remove count-based query assertions Nov 16, 2022
@leplatrem leplatrem mentioned this issue Nov 16, 2022
Merged
leplatrem added a commit that referenced this issue Nov 22, 2022
@leplatrem
Fix #457: Rework query assertions (#459)
3d0c007 
* Replace assertions on length by assertions on fields

* Remove assertions about low level queries

* Remove unused StatementWatcher
@grahamalama grahamalama linked a pull request Jan 23, 2023 that will close this issue
Remove SQL assertions #520
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leplatrem leplatrem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #457: Rework query assertions leplatrem/ctms-api
Remove SQL assertions mozilla-it/ctms-api
2 participants
@leplatrem @bsieber-mozilla