Run linting outside Docker #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Thanks!
That's a lot more convenient without Docker.
I faced this when running make lint:
Installing dependencies from lock file
No dependencies to install or update
touch .venv/.install.stamp
touch: .venv/.install.stamp: No such file or directory
make: *** [.venv/.install.stamp] Error 1
That's because I had a virtualenv already in use, and poetry wouldn't recreate a new one in .venv. Deleting it solved the issue:
poetry env list
poetry env remove ctms-GGbMHGG7-py3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #462