Move testing outside Docker, simplify Dockerfile #508
Conversation
grahamalama
added
dev
|
TODO: do a once-over of our documentation and update what's now outdated |
Now that we run tests outside of the Docker container, we now only need two stages in our multistage build: - one stage to build Python dependencies - another stage to copy in the dependencies and run the application
Also, alpha sort make rules
grahamalama
force-pushed
the
tests-outside-container
branch
from
87f8fd8 to
2dce047
Compare
grahamalama
force-pushed
the
tests-outside-container
branch
from
2dce047 to
be58863
Compare
There was a problem hiding this comment.
Woah! Docker is way simpler with this change--thanks @grahamalama !
|
Thanks for the review @bsieber-mozilla! @bkochendorfer, care to give this a once-over before we ship this to staging since this is a pretty big change to how we build the container? |
| target: "development" | ||
| tags: ghcr.io/${{ github.repository }}:${{ github.sha }} | ||
|
|
||
| python-version: "3.10" |
There was a problem hiding this comment.
will dependabot notice and be able to update this python-version; or is that something for us to keep in mind?
There was a problem hiding this comment.
I think this is something we'll just have to remember, unfortunately. But it would definitely be nice if we could keep these things in sync. Maybe there's a way 🤔
@bkochendorfer for moving scripts, I just wanted to consolidate all scripts into one place. In fact, in a future PR, I might move scripts from As for why I chose |
Addresses #462
In this PR, we move testing outside of Docker. Since the Dockerfile is now only responsible for building a production container, we also simplify the Dockerfile accordingly.