Streamline environment bootstrapping, move contents of `docker/` to top level #510

grahamalama · 2023-01-13T20:42:53Z

In this PR, we:

consolidate sources of local development config (.env.dist local_dev.env) to one .env.example, which is copied to .env with Make
move contents of docker/ to top level, which allows us to remove some config options with Docker commands
delete docker/log_config.json, which appeared to be unused

bsieber-mozilla

Nice! Thanks for organizing and cleaning this code up!
🚢

Delete local_dev.env, and move all environment variable bootstrapping .env.example

Makefile

Make does this automatically

grahamalama added the dev Enhancements to development environment label Jan 13, 2023

grahamalama marked this pull request as ready for review January 13, 2023 20:43

grahamalama requested a review from a team as a code owner January 13, 2023 20:43

bsieber-mozilla approved these changes Jan 13, 2023

View reviewed changes

grahamalama force-pushed the streamline-env branch from ffa9b26 to e135c7c Compare January 20, 2023 15:53

grahamalama added 7 commits January 20, 2023 12:10

Remove unused log_config.json file

a46af92

Move all env var bootstrapping to .env.example

4a3c248

Delete local_dev.env, and move all environment variable bootstrapping .env.example

Move Dockerfile to root directory

909454e

Add poetry run to update_baseline.sh

48ce45b

Update .secrets.baseline

bd57608

remove .env requirement from lint rule

d32735c

Add .DS_STORE to .gitignore

bff85a2

grahamalama force-pushed the streamline-env branch from e135c7c to bff85a2 Compare January 20, 2023 17:10

leplatrem approved these changes Jan 24, 2023

View reviewed changes

Makefile Outdated Show resolved Hide resolved

Remove guard in .env rule

33d54df

Make does this automatically

grahamalama merged commit b037a13 into main Jan 24, 2023

grahamalama deleted the streamline-env branch January 24, 2023 21:10

Provide feedback