Ref #548: make basket_token field optional in contact responses body #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
reviewed
Feb 16, 2023
There was a problem hiding this comment.
Could you please be a bit more specific in the PR title?
For example, make basket_token field optional in contact responses body, or something like that.
Those PR titles show up directly in our CHANGELOG, and need to help readers understand what changed concretely in the release.
I'm OK with the change. Although I would feel more comfortable if it had an accompanying test (eg. unset the contact basket token field and delete it).
ahoneiser
changed the title
ahoneiser
force-pushed
the
fix-identityresponse-model
branch
from
5b7931d to
485b7b5
Compare
leplatrem
approved these changes
Feb 17, 2023
leplatrem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #548