Add make format command
#568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
add-format-directive
branch
from
3909172 to
37403e5
Compare
grahamalama
reviewed
Mar 3, 2023
Comment on lines
-1
to
+3
| #!/bin/bash | ||
| #!/bin/sh | ||
|
|
||
| set -euo pipefail | ||
| set -e |
There was a problem hiding this comment.
What was the motivation for these changes?
There was a problem hiding this comment.
Just because I took it from https://github.com/mozilla/jira-bugzilla-integration/blob/main/bin/lint.sh
There was a problem hiding this comment.
Well, initially I was going to suggest keeping this the way it is and migrating JBI to "bash strict mode".
But turns out there are some gotchas with that approach as well.
So, maybe -euo pipefail is "safer", if not too safe, but this could also be fine as is, since I'm less convinced about the safety that these flags provide.
grahamalama
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint.shtaken from https://github.com/mozilla/jira-bugzilla-integration/blob/main/bin/lint.sh