Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish moving Stripe data out of sample_data.py #632

Merged
merged 6 commits into from
Apr 13, 2023

Conversation

grahamalama
Copy link
Contributor

Follow up of #628 and #629

The overall goal of this PR was to move all of the remaining functions / data out of sample_data.py to delete that module. Here's how we did that:

  • Use fixture data (instead of FAKE_STRIPE_ID) to make assertions.
    • In some cases, we had to pull in fixtures that weren't already provided. This will hopefully be a temporary measure while we refactor tightly coupled fixtures
  • Convert FAKE_STRIPE_ID to constants in conftest.py
  • Use fake_stripe_id in tests and fixtures that don't need FAKE_STRIPE_ID

@grahamalama grahamalama requested a review from a team as a code owner April 13, 2023 13:23
@grahamalama grahamalama added the dev Enhancements to development environment label Apr 13, 2023
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (GG on removing sample_data.py 🎉)

@grahamalama grahamalama merged commit 786281e into main Apr 13, 2023
@grahamalama grahamalama deleted the remove-sample-stripe-data branch April 13, 2023 15:14
@grahamalama grahamalama linked an issue Apr 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Enhancements to development environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace static fixtures with factory-generated fixtures
2 participants