Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove indirection in getting contacts #661

Merged
merged 2 commits into from
May 4, 2023
Merged

Remove indirection in getting contacts #661

merged 2 commits into from
May 4, 2023

Conversation

grahamalama
Copy link
Contributor

@grahamalama grahamalama commented May 3, 2023 •
edited
Loading

This PR tweaks the way we query for contacts by email_id or my multiple IDs. Now, get_contacts_by_email_id returns a Contact object directly, and we combine the various functions we had to query multiple contacts into one get_contacts_by_any_id function.

grahamalama added 2 commits May 3, 2023 11:38
@grahamalama
Return Contact object directly from get_contact_by_email_id
97d7a4f 
Also, removes get_acoustic_record_as_contact, because now that is the
same as the new behavior of get_contact_by_email_id
@grahamalama
Use get_contacts_by_any_id for all queries with multiple IDs
5c473cf
@grahamalama grahamalama requested a review from a team as a code owner May 3, 2023 16:15
@grahamalama grahamalama added the enhancement New feature or request label May 3, 2023
leplatrem
leplatrem approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick 🤩

From the changed lines, I couldn't spot any potential query degradation 💯

@grahamalama grahamalama merged commit 7323dab into main May 4, 2023
@grahamalama grahamalama deleted the get-contact-by-email-id branch May 4, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leplatrem leplatrem leplatrem approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamalama @leplatrem