Add method to generate a Contact from an Email
#663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
approved these changes
May 10, 2023
ctms/schemas/contact.py
Outdated
| return by_product | ||
|
|
||
|
|
||
| def _product_metadata(subscriptions_by_product): |
There was a problem hiding this comment.
Adding a comment may help here, at least explaining that we pick the latest product from the subscription dict values
There was a problem hiding this comment.
@leplatrem ended up going in a pretty different direction for these functions, so retagging you for review.
leplatrem
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
ContactSchema.from_emailmethod so that we can consolidate that logic (that is, generating aContactfrom anEmailobject) in one place.