Fix #611: ContactSchema now reflects what is stored in database
#711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
611-models-acoustic-sync
branch
2 times, most recently
from
f41c77a to
1696c47
Compare
leplatrem
force-pushed
the
611-models-acoustic-sync
branch
from
1696c47 to
4c4c853
Compare
grahamalama
reviewed
Jun 26, 2023
There was a problem hiding this comment.
instances coming the database (
*Table*schemas)
I saw this and was slightly thrown by the naming introduced in d0e27b0, since there's no "Contact" table in the database. Is this to mean "a contact comprised entirely of *TableSchema objects?
Because there is not contact table in the database :) This reverts commit d0e27b0.
grahamalama
approved these changes
Jun 27, 2023
Co-authored-by: grahamalama <gbeckley@mozilla.com>
leplatrem
added a commit
that referenced
this pull request
Jun 29, 2023
leplatrem
added a commit
that referenced
this pull request
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies a bit that we are sometimes dealing with instances coming the database (
*Table*schemas) and instances coming as input (*In*schemas).It fixes bug #611 where timestamps were dropped during the Acoustinc sync process (because objects from the database were casted to input objects that don't have timestamp fields)