Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine CI checks into one workflow #744

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Combine CI checks into one workflow #744

merged 2 commits into from
Jul 6, 2023

Conversation

grahamalama
Copy link
Contributor

I think this better-fits the "mental model" of Github actions workflows -- instead of one workflow file per job, each workflow file should represent a, well, workflow e.g. deploy, ci. That workflow may be composed of 1 or more jobs that run to fulfill that workflow.

@grahamalama grahamalama requested a review from a team as a code owner July 6, 2023 13:08
@grahamalama
Copy link
Contributor Author

Because we have run_test as a required check, but now the job is called run_unit_tests, I think we'll have to bypass branch protections for this PR (if we decide to merge it), then update the branch protections accordingly

Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could become a potential quality standard :) I take note of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants