Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #562: add subscribed field to newsletters Acoustic relational table #752

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Fix #562: add subscribed field to newsletters Acoustic relational table #752

merged 4 commits into from
Jul 25, 2023

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Jul 7, 2023 •
edited
Loading

Fix #562

  • Basic code
  • Add tests for unsubscribed newsletters
  • Add docs for Acoustic queries

@leplatrem leplatrem added the enhancement New feature or request label Jul 7, 2023
@leplatrem leplatrem marked this pull request as ready for review July 10, 2023 18:16
@leplatrem leplatrem requested a review from a team as a code owner July 10, 2023 18:16
grahamalama
grahamalama approved these changes Jul 11, 2023
View reviewed changes
ctms/acoustic_service.py Outdated Show resolved Hide resolved
tests/unit/test_acoustic_service.py Show resolved Hide resolved
@leplatrem leplatrem merged commit 0666421 into main Jul 25, 2023
@leplatrem leplatrem deleted the 562-newsletter-subscribed-field-acoustic branch July 25, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamalama grahamalama grahamalama approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync newsletter subscribed flag to Acoustic relational table
2 participants
@leplatrem @grahamalama