Turn suppression list CSV into a set of SQL files to be ran on the server #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
apply-suppression-list
branch
3 times, most recently
from
aeb8db9 to
a79e69e
Compare
leplatrem
force-pushed
the
apply-suppression-list
branch
from
a79e69e to
4b6fdb5
Compare
alexcottner
reviewed
Mar 14, 2024
alexcottner
reviewed
Mar 14, 2024
suppression-list/csv2optout.py
Outdated
| END; | ||
| $$; | ||
|
|
||
| CREATE TEMPORARY TABLE IF NOT EXISTS imported_{tmp_suffix} ( |
There was a problem hiding this comment.
Why do we need a table suffix for a temp table? The table would be dropped at the end of the session by default (or at the end of a transaction if we specify on commit drop)
There was a problem hiding this comment.
Yes, you're right, this is not necessary
alexcottner
reviewed
Mar 14, 2024
leplatrem
changed the title
alexcottner
approved these changes
Mar 18, 2024
|
I'll merge this because it was done. If the location in the repo is not adecuate, I'm happy to move it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
estimate time of execution of join query on primary_email in prodturn joins into batches