Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more fixtures #975

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Remove more fixtures #975

merged 9 commits into from
Oct 1, 2024

Conversation

grahamalama
Copy link
Contributor

This PR edits a few more tests so that we can remove the minimal / maximal contact fixtures.

The data that was used to create those fixtures is still used in one test, but in a follow-up PR we'll do that final cleanup.

@grahamalama grahamalama requested a review from a team as a code owner September 27, 2024 14:49
@leplatrem leplatrem added the enhancement New feature or request label Sep 30, 2024
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Graham! 💯 Congrats for your patience on this.
I reviewed per commit and all seems sound 👌

tests/unit/routers/contacts/test_api.py Show resolved Hide resolved
tests/unit/test_crud.py Show resolved Hide resolved
tests/unit/routers/contacts/test_api_get.py Show resolved Hide resolved
@grahamalama grahamalama merged commit 72b8224 into main Oct 1, 2024
6 of 7 checks passed
@grahamalama grahamalama deleted the remove-more-fixtures branch October 1, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants