Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change codeowners from syseng to robhudson #997

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

grahamalama
Copy link
Contributor

No description provided.

@grahamalama grahamalama requested a review from a team as a code owner November 12, 2024 14:02
@grahamalama
Copy link
Contributor Author

@robhudson, who else should we add here, if anyone?

# see http://code.v.igoro.us/posts/2019/07/codeowners.html

* @mozilla-it/syseng
* @robhudson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also add @mozmeao/backend to include the 3 of us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a team in https://github.com/orgs/mozilla-it/? All I was able to find was https://github.com/orgs/mozilla-it/teams/mozmeao. I don't think you can do cross-org codeownership like that, unfortunately

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, makes sense. We could use the @mozmeao one. I think it would be nice to have a "main" but also a team as fallback.

@robhudson
Copy link
Collaborator

Updated to use * @mozilla-it/ctms-reviewers to more easily manage.

@robhudson robhudson merged commit eb0b2d4 into main Nov 12, 2024
5 checks passed
@robhudson robhudson deleted the change-codeowners branch November 12, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants