Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract new strings (2023-11-17) #208

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Extract new strings (2023-11-17) #208

merged 1 commit into from
Nov 17, 2023

Conversation

mozilla-pontoon
Copy link
Collaborator

Automated changes by create-pull-request GitHub action

@mozilla-pontoon mozilla-pontoon requested a review from a team as a code owner November 14, 2023 15:06
@Delphine
Copy link
Contributor

Had a chat with iOS team yesterday, they need to update strings here and cancel the removals.

@thatswinnie
Copy link

@Delphine @lmarceau and I solved it 😆 : the strings for the ids Shopping.InfoCard.ReportSubmittedByCurrentUser.Description.v121 and Shopping.InfoCard.ReportSubmittedByCurrentUser.Title.v121 are removed and later in the same file added again.
Could you please pull the strings again to get the missing strings from our repo?

@mozilla-pontoon mozilla-pontoon changed the title Extract new strings (2023-11-14) Extract new strings (2023-11-16) Nov 16, 2023
@Delphine
Copy link
Contributor

Delphine commented Nov 16, 2023

@thatswinnie Actually I see that these strings did change files, which is the reason it invalidates translations for these strings. They now live under <file original="Shared/Supporting Files/en.lproj/Shopping.strings"
You can tell that moving strings to another file will invalidate existing translations by for example searching for those two strings under "fr" xliff strings: they were initially translated in French when the strings were in the previous file, and now adding back you can see they are only in English).

Is there a reason we are moving both these strings to a different file?

@Delphine
Copy link
Contributor

Actually I have a workaround for this so I might be able to fix this on my side 🙂

@mozilla-pontoon mozilla-pontoon changed the title Extract new strings (2023-11-16) Extract new strings (2023-11-17) Nov 17, 2023
@Delphine Delphine merged commit 53179cf into main Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants