This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Change fetchProvidedTopSites into TopSitesProviderConfig #11654
Comments
gabrielluong
added a commit
to gabrielluong/android-components
that referenced
this issue
Feb 4, 2022
…a function This changes `fetchProvidedTopSites` into a lambda function `shouldFetchTopSitesFromProvider` that takes the number of existing top sites as a parameter to determine whether or not to fetch top sites from the `TopSitesProvider`.
4 tasks
gabrielluong
added a commit
to gabrielluong/android-components
that referenced
this issue
Feb 4, 2022
…a function This changes `fetchProvidedTopSites` into a lambda function `shouldFetchTopSitesFromProvider` that takes the number of existing top sites as a parameter to determine whether or not to fetch top sites from the `TopSitesProvider`.
gabrielluong
added a commit
to gabrielluong/android-components
that referenced
this issue
Feb 4, 2022
…a function This changes `fetchProvidedTopSites` into a lambda function `shouldFetchTopSitesFromProvider` that takes the number of existing top sites as a parameter to determine whether or not to fetch top sites from the `TopSitesProvider`.
gabrielluong
added a commit
to gabrielluong/android-components
that referenced
this issue
Feb 7, 2022
…a function This changes `fetchProvidedTopSites` into a lambda function `shouldFetchTopSitesFromProvider` that takes the number of existing top sites as a parameter to determine whether or not to fetch top sites from the `TopSitesProvider`.
gabrielluong
added a commit
to gabrielluong/android-components
that referenced
this issue
Feb 7, 2022
…sProviderConfig This changes `fetchProvidedTopSites` into a data class `TopSitesProviderConfig` that specifies whether or not to display the top sites from the provider and the maximum threshold at which to fetch the top sites from the provider.
gabrielluong
changed the title
gabrielluong
added a commit
to gabrielluong/android-components
that referenced
this issue
Feb 7, 2022
…sProviderConfig This changes `fetchProvidedTopSites` into a data class `TopSitesProviderConfig` that specifies whether or not to display the top sites from the provider and the maximum threshold at which to fetch the top sites from the provider.
gabrielluong
added a commit
to gabrielluong/android-components
that referenced
this issue
Feb 7, 2022
…sProviderConfig This changes `fetchProvidedTopSites` into a data class `TopSitesProviderConfig` that specifies whether or not to display the top sites from the provider and the maximum threshold at which to fetch the top sites from the provider.
gabrielluong
added a commit
to gabrielluong/android-components
that referenced
this issue
Feb 8, 2022
…sProviderConfig This changes `fetchProvidedTopSites` into a data class `TopSitesProviderConfig` that specifies whether or not to display the top sites from the provider and the maximum threshold at which to fetch the top sites from the provider.
gabrielluong
added a commit
to gabrielluong/android-components
that referenced
this issue
Feb 8, 2022
…sProviderConfig This changes `fetchProvidedTopSites` into a data class `TopSitesProviderConfig` that specifies whether or not to display the top sites from the provider and the maximum threshold at which to fetch the top sites from the provider.
mergify bot
pushed a commit
that referenced
this issue
Feb 9, 2022
This changes `fetchProvidedTopSites` into a data class `TopSitesProviderConfig` that specifies whether or not to display the top sites from the provider and the maximum threshold at which to fetch the top sites from the provider.
gabrielluong
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In Fenix, we only want to fetch top sites from the provider only if there are < 8 pinned + default sites. We want to introduce a max threshold that prevents fetching top sites from the provider unnecessarilly.
┆Issue is synchronized with this Jira Sub-task
The text was updated successfully, but these errors were encountered: