Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Support reverse landscape orientation for fullscreen videos #12034

Closed
Mugurell opened this issue Apr 20, 2022 · 3 comments
Closed

Support reverse landscape orientation for fullscreen videos #12034

Mugurell opened this issue Apr 20, 2022 · 3 comments
Assignees
@indurs

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Apr 20, 2022 •
edited by data-sync-user
Loading

Needed to support mozilla-mobile/fenix#24678

@indurs posted in mozilla-mobile/fenix#24678 (comment)

to play the video both in landscape and landscape reverse, when auto rotate is disabled we can use

activity.requestedOrientation =
                    ActivityInfo.SCREEN_ORIENTATION_SENSOR_LANDSCAPE

instead of

activity.requestedOrientation =
                    ActivityInfo.SCREEN_ORIENTATION_USER_LANDSCAPE

in MediaSessionFullscreenFeature
https://github.com/mozilla-mobile/android-components/blob/62fe384048d6c4048c0ddd60befa1158774b3589/components>/feature/media/src/main/java/mozilla/components/feature/media/fullscreen/MediaSessionFullscreenFeature.kt#L55

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell mentioned this issue Apr 20, 2022
Closed
@indurs
Copy link
Contributor

indurs commented Apr 20, 2022

@Mugurell , can I work on this issue?

indurs added a commit to indurs/android-components that referenced this issue Apr 21, 2022
@indurs
For mozilla-mobile#12034 - Support reverse landscape orientation for …
f1cdc90 
…fullscreen videos

This allows users to view the full screen video both in landscape and reverse landscape even when auto rotate option is disabled in device settings
@indurs
Copy link
Contributor

indurs commented Apr 21, 2022

Created a PR for this issue. But there was an error
"Failed to fetch task artifact public/github/customCheckRunText.md for GitHub integration.
Make sure the artifact exists on the worker or other location."
Not sure what it means..

@Mugurell
Copy link
Contributor Author

Also saw a test failing. Left a comment on the PR.

Mugurell pushed a commit to indurs/android-components that referenced this issue Apr 29, 2022
@indurs @Mugurell
For mozilla-mobile#12034 - Support reverse landscape orientation for …
2dd9fb0 
…fullscreen videos

This allows users to view the full screen video both in landscape and reverse landscape even when auto rotate option is disabled in device settings
mergify bot pushed a commit that referenced this issue Apr 29, 2022
@indurs @mergify
For #12034 - Support reverse landscape orientation for fullscreen videos
8c2e29c 
This allows users to view the full screen video both in landscape and reverse landscape even when auto rotate option is disabled in device settings
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@indurs indurs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonalmeida @Mugurell @indurs