Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Cancel in-progress history suggestions requests #12469

Closed
Mugurell opened this issue Jul 11, 2022 · 0 comments · Fixed by #12496 or nathanmkaya/android-components#362
Closed

Cancel in-progress history suggestions requests #12469

Mugurell opened this issue Jul 11, 2022 · 0 comments · Fixed by #12496 or nathanmkaya/android-components#362
Assignees
@Mugurell
Milestone
104.0.0 🥵

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Jul 11, 2022 •
edited by data-sync-user
Loading

As a follow-up to mozilla-mobile/fenix#25875 and based on the discussions with @mhammond we should cancel all in-progress requests before making another ones to prevent against them being queued and so delaying getting the results for the last entered text for which we should provide suggestions.
For this we should use PlacesConnection.interrupt().

Important details:

  • the interrupt calls will cancel all reads so we need to ensure the PlacesReaderConnection is not used for other unrelated requests also.
  • the in-progress calls will fail with a special "OperationInterrupted" error, so we probably need to make sure these aren't reported to sentry or cause too much noise anywhere.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell self-assigned this Jul 11, 2022
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 11, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel previous queries before new suggest…
122f368 
…ions requests
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 11, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel previous queries before new suggest…
86a6680 
…ions requests
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 11, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel previous queries before new suggest…
bdac013 
…ions requests
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 11, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel previous queries before new suggest…
3c676fe 
…ions requests
mergify bot pushed a commit that referenced this issue Jul 11, 2022
@Mugurell @mergify
For #12469 - Cancel previous queries before new suggestions requests
b5de3aa
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 14, 2022
@Mugurell
For mozilla-mobile#12469 - Allow for multiple PlacesApi readers.
2a7132b 
Multiple readers allow to start and cancel history suggestions requests without
any impact on other in-progress PlacesApi queries.
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 14, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel all in progress history reads befor…
1ad2f64 
…e new queries
@github-actions github-actions bot mentioned this issue Jul 14, 2022
Merged
4 tasks
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 15, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel in progress storage requests before…
9095788 
… new awesomebar suggestions
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 15, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel in progress storage requests before…
7a50d21 
… new awesomebar suggestions
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 15, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel in progress storage requests before…
54e4dc8 
… new awesomebar suggestions
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 15, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel in progress storage requests before…
4440151 
… new awesomebar suggestions
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 15, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel in progress storage requests before…
f3f9b5e 
… new awesomebar suggestions
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 18, 2022
@Mugurell
For mozilla-mobile#12469 - Cancel in progress storage requests before…
95b545b 
… new awesomebar suggestions
@mergify mergify bot closed this as completed in #12496 Jul 18, 2022
mergify bot pushed a commit that referenced this issue Jul 18, 2022
@Mugurell @mergify
For #12469 - Cancel in progress storage requests before new awesomeba…
b9d28c5 
…r suggestions
@github-actions github-actions bot added this to the 104.0.0 🥵 milestone Jul 18, 2022
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 19, 2022
@Mugurell
For mozilla-mobile#12469 - Fix leak.
e16d23e
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 19, 2022
@Mugurell
For mozilla-mobile#12469 - Some tests
d7e716e
@github-actions github-actions bot mentioned this issue Jul 19, 2022
Merged
4 tasks
@Mugurell Mugurell mentioned this issue Jul 28, 2022
Closed
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 28, 2022
@Mugurell
For mozilla-mobile#12469 - Stop logging AS-places reads/writes explic…
4713450 
…it interrupts

The OperationInterrupted exceptions are expected so logging them to the crash
servers has little use.
@github-actions github-actions bot mentioned this issue Jul 28, 2022
Merged
4 tasks
@Mugurell Mugurell mentioned this issue Jul 29, 2022
Closed
@github-actions github-actions bot mentioned this issue Sep 13, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Mugurell Mugurell

Labels
None yet
Projects
None yet
Milestone
104.0.0 🥵
1 participant
@Mugurell