Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Canceling the "Open in app?" displays an empty page #12894

Closed
iorgamgabriel opened this issue Oct 5, 2022 · 3 comments · Fixed by #12897
Closed

Canceling the "Open in app?" displays an empty page #12894

iorgamgabriel opened this issue Oct 5, 2022 · 3 comments · Fixed by #12897
Assignees
@rocketsroger
Labels
<app-links> Component: feature-app-links
Milestone
107.0.0 🎃

Comments

@iorgamgabriel
Copy link
Contributor

iorgamgabriel commented Oct 5, 2022 •
edited by data-sync-user
Loading

Prerequisites

Have Youtube, or Maps apps installed.

Steps to reproduce

  1. Go to Settings - Advanced, and enable the "Open links in apps" toggle.
  2. Exit settings, and go to youtube.com, or maps.google.com.
  3. On the "Open in apps?" tap on "Cancel".
  4. Observe the page.

Expected behavior

The page loads in browser, without issues.

Actual behavior

The page is blank.

The original ticket from Focus mozilla-mobile/focus-android#7777
This bug was introduced with this pr #12382

  • Android device: all devices
  • App (fenix, focus, ...): focus
  • App version: from 103 until present

┆Issue is synchronized with this Jira Task
@iorgamgabriel iorgamgabriel added the performance Performance related issues label Oct 5, 2022
iorgamgabriel added a commit to iorgamgabriel/android-components that referenced this issue Oct 5, 2022
@iorgamgabriel
For mozilla-mobile#12894 Canceling the "Open in app?" displays an emp…
2ddf3ba 
…ty page
iorgamgabriel added a commit to iorgamgabriel/android-components that referenced this issue Oct 5, 2022
@iorgamgabriel
For mozilla-mobile#12894 Canceling the "Open in app?" displays an emp…
7c6387d 
…ty page
@github-actions github-actions bot mentioned this issue Oct 5, 2022
Closed
4 tasks
iorgamgabriel added a commit to iorgamgabriel/android-components that referenced this issue Oct 5, 2022
@iorgamgabriel
For mozilla-mobile#12894 Canceling the "Open in app?" displays an emp…
7edb960 
…ty page
@github-actions github-actions bot mentioned this issue Oct 5, 2022
Merged
4 tasks
iorgamgabriel added a commit to iorgamgabriel/android-components that referenced this issue Oct 6, 2022
@iorgamgabriel
For mozilla-mobile#12894 Canceling the "Open in app?" displays an emp…
4aef495 
…ty page
iorgamgabriel added a commit to iorgamgabriel/android-components that referenced this issue Oct 6, 2022
@iorgamgabriel
For mozilla-mobile#12894 Canceling the "Open in app?" should open the…
4bc72fd 
… page in focus browser.
iorgamgabriel added a commit to iorgamgabriel/android-components that referenced this issue Oct 10, 2022
@iorgamgabriel
For mozilla-mobile#12894 Canceling the "Open in app?" should open the…
b4714e7 
… page in focus browser.
iorgamgabriel added a commit to iorgamgabriel/android-components that referenced this issue Oct 10, 2022
@iorgamgabriel
For mozilla-mobile#12894 Canceling the "Open in app?" should open the…
9edfa10 
… page in focus browser.
iorgamgabriel added a commit to iorgamgabriel/android-components that referenced this issue Oct 10, 2022
@iorgamgabriel
For mozilla-mobile#12894 Canceling the "Open in app?" should open the…
28ee1bf 
… page in focus browser.
@mergify mergify bot closed this as completed in #12897 Oct 11, 2022
mergify bot pushed a commit that referenced this issue Oct 11, 2022
@iorgamgabriel @mergify
For #12894 Canceling the "Open in app?" should open the page in focus…
3465b80 
… browser.
@github-actions github-actions bot added this to the 107.0.0 🍂 milestone Oct 11, 2022
@rocketsroger
Copy link
Contributor

Reopening to fix the root cause

@rocketsroger rocketsroger reopened this Oct 11, 2022
@rocketsroger
Copy link
Contributor

The root cause is that we need to have some way of loading URI without it intercepted even when interceptsAppInitiatedRequests is set to true.

@MarcLeclair MarcLeclair added <app-links> Component: feature-app-links and removed performance Performance related issues labels Oct 12, 2022
@rocketsroger rocketsroger self-assigned this Oct 13, 2022
JohanLorenzo pushed a commit to mozilla-mobile/firefox-android that referenced this issue Oct 13, 2022
@iorgamgabriel @mergify
[components] For mozilla-mobile/android-components#12894 Canceling th…
99fec6d 
…e "Open in app?" should open the page in focus browser.
iorgamgabriel added a commit to iorgamgabriel/android-components that referenced this issue Oct 17, 2022
@iorgamgabriel
For mozilla-mobile#12894 Canceling the "Open in app?" should open the…
94715d7 
… page in focus browser.
@github-actions github-actions bot mentioned this issue Oct 17, 2022
Merged
4 tasks
iorgamgabriel added a commit to iorgamgabriel/android-components that referenced this issue Oct 17, 2022
@iorgamgabriel
For mozilla-mobile#12894 Canceling the "Open in app?" should open the…
18b57f4 
… page in focus browser.
@jonalmeida
Copy link
Contributor

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1796657

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
<app-links> Component: feature-app-links
Projects
None yet
Milestone
107.0.0 🎃
4 participants
@jonalmeida @rocketsroger @iorgamgabriel @MarcLeclair