Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Dynamically set menu direction in MenuBuilder #2916

Closed
sblatz opened this issue May 2, 2019 · 4 comments
Closed

Dynamically set menu direction in MenuBuilder #2916

sblatz opened this issue May 2, 2019 · 4 comments
Assignees
@Amejia481
Labels
🐉 Fenix Feature needed for Fenix <menu> Component: concept-menu, browser-menu, browser-menu2 P1
Milestone
0.56.0 🎯

Comments

@sblatz
Copy link
Contributor

sblatz commented May 2, 2019 •
edited by data-sync-user
Loading

When I set the the browser menu direction of a MenuBuilder to be UP it is not respected. It seems like only DOWN (the default param) is ever set.

┆Issue is synchronized with this Jira Task
@sblatz sblatz added 🐉 Fenix Feature needed for Fenix <menu> Component: concept-menu, browser-menu, browser-menu2 labels May 2, 2019
@pocmo
Copy link
Contributor

pocmo commented May 8, 2019

What are you trying to do? The UP/DOWN behavior seems to work for the top/bottom toolbar.

@sblatz
Copy link
Contributor Author

sblatz commented May 8, 2019 •
edited
Loading

@pocmo I have a menu button towards the bottom of the screen that I want to expand upwards. When I set the direction to "UP" it still goes Down.

Perhaps what I really want, though, is a menu builder that dynamically chooses which to use based on its proximity to the top or bottom of the screen (though that is likely much harder than this fix)

@pocmo pocmo added the SV label May 22, 2019
@sblatz sblatz mentioned this issue May 31, 2019
Closed
@sblatz sblatz changed the title Menu direction is not respected in MenuBuilder Dynamically set menu direction in MenuBuilder May 31, 2019
@sblatz
Copy link
Contributor Author

sblatz commented May 31, 2019 •
edited
Loading

Looks like we may want to change the determineMenuOrientation function.

Perhaps we could pass in getRectWithViewLocation() and determine spacing to the bottom/top of the screen based on that?

@sblatz
Copy link
Contributor Author

sblatz commented May 31, 2019 •
edited
Loading

Blocking three fenix issues: mozilla-mobile/fenix#2162 & mozilla-mobile/fenix#986 & mozilla-mobile/fenix#2825

This was referenced May 31, 2019
Closed
Closed
@vesta0 vesta0 added the P1 label May 31, 2019
@Amejia481 Amejia481 self-assigned this May 31, 2019
@Amejia481 Amejia481 mentioned this issue Jun 4, 2019
Closed
Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 5, 2019
@Amejia481
Closes mozilla-mobile#2916: Added BrowserMenu.Orientation.DYNAMIC
6f53ba9
Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 5, 2019
@Amejia481
Closes mozilla-mobile#2916: Added BrowserMenu.Orientation.DYNAMIC.
d7fd87a
Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 5, 2019
@Amejia481
Closes mozilla-mobile#2916: Added BrowserMenu.Orientation.DYNAMIC.
842ac4d
Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 7, 2019
@Amejia481
Closes mozilla-mobile#2916: Improve BrowserMenu popup orientation.
358358a
Amejia481 added a commit to Amejia481/android-components that referenced this issue Jun 7, 2019
@Amejia481
Closes mozilla-mobile#2916: Improve BrowserMenu popup orientation.
0e99af6
@Amejia481 Amejia481 added this to the 0.56.0 🎯 milestone Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
🐉 Fenix Feature needed for Fenix <menu> Component: concept-menu, browser-menu, browser-menu2 P1
Projects
None yet
Milestone
0.56.0 🎯
Development

No branches or pull requests
4 participants
@pocmo @Amejia481 @sblatz @vesta0