Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

[Bug] "Open with" dialogue opens when interacting with website's search #3944

Closed
vesta0 opened this issue Jul 29, 2019 · 2 comments · Fixed by mozilla-mobile/fenix#4413
Closed

[Bug] "Open with" dialogue opens when interacting with website's search #3944

vesta0 opened this issue Jul 29, 2019 · 2 comments · Fixed by mozilla-mobile/fenix#4413
Assignees
@pocmo
Labels
🔥 release blocker Needs to land for the next release P1
Milestone
7.0.0 ☀️

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Jul 29, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

-Open Fenix and navigate to Amazon.ca
-Type something in the website's search box
-Tap on X to clear the search

(you can also replicate when interacting with website's search on freshcityfarms.com

Expected behavior

Search clears

Actual behavior

Search clears AND Open with browser dialogue opens

Device information

  • Android device: Pixel 3
  • Fenix version: Nightly 190726

Screenshot_20190729-134351

┆Issue is synchronized with this Jira Task
@vesta0 vesta0 added the P1 label Jul 29, 2019
@vesta0 vesta0 changed the title [Bug] Open with dialogue opens when interacting with website's search [Bug] "Open with" dialogue opens when interacting with website's search Jul 29, 2019
@pocmo pocmo self-assigned this Jul 29, 2019
@pocmo pocmo added the 🔥 release blocker Needs to land for the next release label Jul 29, 2019
@pocmo
Copy link
Contributor

pocmo commented Jul 30, 2019

In this case a request for javascript:; gets triggered. One option would be to just ignore the javascript scheme. But I'll explore some other options first.

pocmo added a commit to pocmo/android-components that referenced this issue Jul 30, 2019
@pocmo
Issue mozilla-mobile#3944: Enable link interception (AppLinksFeature)…
d6dad6a 
… in sample browser.
pocmo added a commit to pocmo/android-components that referenced this issue Jul 30, 2019
@pocmo
Closes mozilla-mobile#3944: AppLinksFeature: Do not open third-party …
0229a1a 
…apps for URLs with javascript scheme.
@pocmo pocmo added this to the 7.0.0 milestone Jul 30, 2019
pocmo added a commit to pocmo/android-components that referenced this issue Jul 30, 2019
@pocmo
Issue mozilla-mobile#3944: Enable link interception (AppLinksFeature)…
64418cb 
… in sample browser.
pocmo added a commit to pocmo/android-components that referenced this issue Jul 30, 2019
@pocmo
Closes mozilla-mobile#3944: AppLinksFeature: Do not open third-party …
3a8b979 
…apps for URLs with javascript scheme.
jonalmeida pushed a commit that referenced this issue Jul 30, 2019
@pocmo @jonalmeida
Issue #3944: Enable link interception (AppLinksFeature) in sample bro…
2925e47 
…wser.
pocmo added a commit that referenced this issue Jul 31, 2019
@pocmo
Closes #3944: AppLinksFeature: Do not open third-party apps for URLs …
57b6cff 
…with javascript scheme.
@pocmo
Copy link
Contributor

pocmo commented Jul 31, 2019

I'll trigger the AC 6.0.1 release build now to get that out for the next Fenix release.

@pocmo pocmo mentioned this issue Jul 31, 2019
Merged
@makotom makotom mentioned this issue Aug 20, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
🔥 release blocker Needs to land for the next release P1
Projects
None yet
Milestone
7.0.0 ☀️
Development

Successfully merging a pull request may close this issue.

Update to use Mozilla Android Components 6.0.1. pocmo/fenix
2 participants
@pocmo @vesta0