Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add global "sync ping", add UUID to all sync pings #5371

Closed
grigoryk opened this issue Dec 19, 2019 · 0 comments · Fixed by #5386
Closed

Add global "sync ping", add UUID to all sync pings #5371

grigoryk opened this issue Dec 19, 2019 · 0 comments · Fixed by #5386
Assignees
@grigoryk
Labels
E3 Estimation points: 3 <sync> Component: sync-logins

Comments

@grigoryk
Copy link
Contributor

grigoryk commented Dec 19, 2019 •
edited by data-sync-user
Loading

We have a concept of a "global sync error", which doesn't map well to per-engine pings. Let's add a "sync" ping to host these global errors.

Additionally, let's expand existing pings to include UUID field, which will be the unique per-sync identifier, allowing us to tie together information emitting by different engines during a sync.

For details and context, see #5294 (comment) and mozilla/application-services#2381

┆Issue is synchronized with this Jira Task
@grigoryk grigoryk added <telemetry> <sync> Component: sync-logins E3 Estimation points: 3 labels Dec 19, 2019
@grigoryk grigoryk self-assigned this Dec 19, 2019
grigoryk pushed a commit to grigoryk/android-components that referenced this issue Dec 20, 2019
Closes mozilla-mobile#5371 - Introduce 'sync' ping, add 'syncUuid' to…
73e17cd 
… all sync-related pings

This patch introduce an 'overarching' sync ping, which is meant to contain information
describing a sync overall, vs individual engine runs. Currently it contains global sync
errors.

syncUuid was also added to all sync-related pings, allowing us to tie together in an
analysis all pings that were emitted as part of a single "sync".
grigoryk pushed a commit to grigoryk/android-components that referenced this issue Dec 24, 2019
Closes mozilla-mobile#5371 - Introduce 'sync' ping, add 'syncUuid' to…
f465730 
… all sync-related pings

This patch introduce an 'overarching' sync ping, which is meant to contain information
describing a sync overall, vs individual engine runs. Currently it contains global sync
errors.

syncUuid was also added to all sync-related pings, allowing us to tie together in an
analysis all pings that were emitted as part of a single "sync".
grigoryk pushed a commit to grigoryk/android-components that referenced this issue Apr 1, 2020
Closes mozilla-mobile#5371 - Introduce 'sync' ping, add 'syncUuid' to…
148f68e 
… all sync-related pings

This patch introduce an 'overarching' sync ping, which is meant to contain information
describing a sync overall, vs individual engine runs. Currently it contains global sync
errors.

syncUuid was also added to all sync-related pings, allowing us to tie together in an
analysis all pings that were emitted as part of a single "sync".
grigoryk pushed a commit to grigoryk/android-components that referenced this issue Apr 1, 2020
Closes mozilla-mobile#5371 - Introduce 'sync' ping, add 'syncUuid' to…
592cf7a 
… all sync-related pings

This patch introduce an 'overarching' sync ping, which is meant to contain information
describing a sync overall, vs individual engine runs. Currently it contains global sync
errors.

syncUuid was also added to all sync-related pings, allowing us to tie together in an
analysis all pings that were emitted as part of a single "sync".
grigoryk pushed a commit to grigoryk/android-components that referenced this issue Apr 2, 2020
Closes mozilla-mobile#5371 - Introduce 'sync' ping, add 'syncUuid' to…
5542721 
… all sync-related pings

This patch introduce an 'overarching' sync ping, which is meant to contain information
describing a sync overall, vs individual engine runs. Currently it contains global sync
errors.

syncUuid was also added to all sync-related pings, allowing us to tie together in an
analysis all pings that were emitted as part of a single "sync".
@grigoryk grigoryk mentioned this issue Apr 2, 2020
Merged
6 tasks
grigoryk pushed a commit to grigoryk/android-components that referenced this issue Apr 2, 2020
Closes mozilla-mobile#5371 - Introduce 'sync' ping, add 'syncUuid' to…
8e0e6a3 
… all sync-related pings

This patch introduce an 'overarching' sync ping, which is meant to contain information
describing a sync overall, vs individual engine runs. Currently it contains global sync
errors.

syncUuid was also added to all sync-related pings, allowing us to tie together in an
analysis all pings that were emitted as part of a single "sync".
@grigoryk grigoryk linked a pull request Apr 6, 2020 that will close this issue
Closes #5371 - Introduce 'sync' ping, add 'syncUuid' to all sync-related pings #5386
Merged
6 tasks
bors bot pushed a commit that referenced this issue Apr 13, 2020
@MozLando
Merge #5386
48e3b99 
5386: Closes #5371 - Introduce 'sync' ping, add 'syncUuid' to all sync-related pings  r=csadilek,Dexterp37,boek a=grigoryk

This patch introduce an 'overarching' sync ping, which is meant to contain information
describing a sync overall, vs individual engine runs. Currently it contains global sync
errors.

syncUuid was also added to all sync-related pings, allowing us to tie together in an
analysis all pings that were emitted as part of a single "sync".




Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
@bors bors bot closed this as completed in 879b8e3 Apr 13, 2020
@skhamis skhamis mentioned this issue Jun 2, 2023
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grigoryk grigoryk

Labels
E3 Estimation points: 3 <sync> Component: sync-logins
Projects
None yet
Milestone
No milestone
1 participant
@grigoryk