Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Call startForegroundService instead of startService on DownloadMiddleware #8363

Closed
Amejia481 opened this issue Sep 9, 2020 · 1 comment
Closed

Call startForegroundService instead of startService on DownloadMiddleware #8363

Amejia481 opened this issue Sep 9, 2020 · 1 comment
Assignees
@Amejia481
Labels
<download> Component: feature-download E3 Estimation points: 3
Milestone
58.0.0 🌽

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Sep 9, 2020 •
edited by data-sync-user
Loading

Related issue mozilla-mobile/fenix#14852

For restoring downloads, we are using context.startService(), this could cause issues as the app could be in background. We should be calling ContextCompat.startForegroundService as we are already fulling the foreground contract .

┆Issue is synchronized with this Jira Task
@Amejia481 Amejia481 changed the title startForegroundService instead of normal service on DownloadMiddleware Call startForegroundService instead of startService on DownloadMiddleware Sep 9, 2020
@Amejia481 Amejia481 self-assigned this Sep 9, 2020
@Amejia481 Amejia481 added the <download> Component: feature-download label Sep 9, 2020
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 9, 2020
@Amejia481
Closes issue mozilla-mobile#8363: Call startForegroundService instead of
d862740 
startService on DownloadMiddleware
Amejia481 added a commit to Amejia481/android-components that referenced this issue Sep 9, 2020
@Amejia481
Closes issue mozilla-mobile#8363: Call startForegroundService instead…
21332cf 
… of startService on DownloadMiddleware
@Amejia481 Amejia481 added the E3 Estimation points: 3 label Sep 9, 2020
@Amejia481 Amejia481 added this to the 58.0.0 🌽 milestone Sep 9, 2020
bors bot pushed a commit that referenced this issue Sep 9, 2020
@MozLando @Amejia481
Merge #8364
8126a6b 
8364: Closes issue #8363: Call startForegroundService instead of startService on DownloadMiddleware r=rocketsroger a=Amejia481




Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
bors bot pushed a commit that referenced this issue Sep 9, 2020
@MozLando @MickeyMoz @Amejia481
Merge #8351 #8362 #8364
81f0f80 
8351: For #8350 - Resize download prompt close_button r=Amejia481 a=codrut-topliceanu



8362:  GeckoView update (beta) (20200909-140929) r=pocmo a=MickeyMoz



8364: Closes issue #8363: Call startForegroundService instead of startService on DownloadMiddleware r=rocketsroger a=Amejia481




Co-authored-by: codrut.topliceanu <codrut.topliceanu@softvision.ro>
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
pocmo pushed a commit that referenced this issue Sep 10, 2020
@Amejia481 @pocmo
Closes issue #8363: Call startForegroundService instead of startServi…
464408c 
…ce on DownloadMiddleware
@Amejia481
Copy link
Contributor Author

Closed by 464408c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
<download> Component: feature-download E3 Estimation points: 3
Projects
None yet
Milestone
58.0.0 🌽
Development

No branches or pull requests
1 participant
@Amejia481